-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added centralized config utilization in Audit for CI Next #146
Merged
eranturgeman
merged 27 commits into
jfrog:dev
from
eranturgeman:centralized-config-implementation
Sep 4, 2024
Merged
Added centralized config utilization in Audit for CI Next #146
eranturgeman
merged 27 commits into
jfrog:dev
from
eranturgeman:centralized-config-implementation
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets and Sast scanners only
…er xsc services files
…o centralized-config-implementation
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 18, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 18, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
…o centralized-config-implementation
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
…o centralized-config-implementation # Conflicts: # utils/xsc/xscmanager.go
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 19, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 25, 2024
attiasas
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!, take a look at my comments
…o centralized-config-implementation
…o centralized-config-implementation # Conflicts: # go.sum # utils/test_mocks.go
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 1, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 1, 2024
eranturgeman
had a problem deploying
to
frogbot
September 2, 2024 13:16
— with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 2, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 2, 2024
attiasas
reviewed
Sep 3, 2024
eranturgeman
had a problem deploying
to
frogbot
September 4, 2024 11:48
— with
GitHub Actions
Failure
…o centralized-config-implementation
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 4, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 4, 2024
attiasas
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.IMPORTANT NOTE: This new capability is currently intended for use by JFrog internal processes ONLY! It will not be supported for customers until the official release!
This PR contain the following changes:
If a Config profile exists it takes priority over definitions in jfrog-apps-config, but, it takes lower prioritization if flags/env variables were provided from CLI while running 'jf audit' (although 'jf audit' is not meant to use this feature yet).
related PR: jfrog/jfrog-client-go#1002